Use managed identity for SQL #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSchlobohm
reviewed
May 9, 2024
KSchlobohm
reviewed
May 9, 2024
twsouthwick
force-pushed
the
sqlpless
branch
3 times, most recently
from
cbef281
to
8ecf26f
Compare
adrianhall
approved these changes
Jun 5, 2024
| @@ -22,6 +22,9 @@ type DeploymentSettings = { | |||
| @description('The ID of the principal that is being used to deploy resources.') | |||
| principalId: string | |||
|
|
|||
| @description('The name of the principal that is being used to deploy resources.') | |||
| principalName: string | |||
There was a problem hiding this comment.
This might be the time to switch over to includes for types. See https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-import
Since you are touching DeploymentSettings everywhere, mark the type here with @export(), then swap out the type definitions everywhere else with an import statement.
There was a problem hiding this comment.
yup, although I believe we're using an older version of bicep that doesn't suppor this. I plan on updating this so we don't have to deal with this in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the SQL admin password and just uses Entra for all logins. The developer is added as an owner so they can bootstrap the application and docs around adding the user have been removed.
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2027162