Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

fix ctrl c not registering issue #906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michelleN
Copy link
Contributor

No description provided.

@faraazkhan
Copy link

faraazkhan commented Dec 10, 2018

Just tested this, works like a charm!
https://asciinema.org/a/VfqIizWrMXVXR4neelM9Lxk5V

FWIW my test environment:

~/D/p/k/d/a/node-backend ❯❯❯ go version
go version go1.11.2 darwin/amd64
~/D/p/k/d/a/node-backend ❯❯❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.3", GitCommit:"435f92c719f279a3a67808c80521ea17d5715c66", GitTreeState:"clean", BuildDate:"2018-11-27T01:14:37Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:05:37Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

This was tested against a k8s cluster with docker-for-desktop.

Thanks for the quick fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants