Allow query result view to be toggled from command bar #1833
+172
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawelton74
previously approved these changes
May 2, 2024
jawelton74
approved these changes
May 3, 2024
languy
reviewed
May 13, 2024
also provides a default results view option that's stored in the browser's local storage
analogrelay
force-pushed
the
ashleyst/toggle-query-results-view
branch
from
50a1d10
to
31b097c
Compare
sunghyunkang1111
approved these changes
Jun 4, 2024
languy
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview this branch
This PR adds a new dropdown to the Query Editor Command Bar:
The options in this menu allow you to toggle between Vertical (editor and results view are stacked vertically; matches the current view) or Horizontal (editor and results view are stacked horizontally, a new layout made available in this PR):
toggle-view-for-query.mp4
The default layout is Vertical, matching the current view. However, this too can be changed using a setting in the Settings pane:
Changing this option will affect the starting view for all future Query Editor panels opened on that Browser (the setting is stored in
localStorage, along with all the existing settings on this pane). Existing opened Query Editors will not be affected:toggle-default-view-for-query.mp4