Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add capacityMode #1826

Merged
merged 2 commits into from
May 17, 2024
Merged

add capacityMode #1826

merged 2 commits into from
May 17, 2024

Conversation

sunghyunkang1111
Copy link
Contributor

@sunghyunkang1111 sunghyunkang1111 commented Apr 28, 2024

Preview this branch

Description
with a breaking change in RP for api version 2024-05-15-preview, contracts need to be updated in the portal.
Adding capacityMode property in database account resource where the account capacitymode is defined rather than in the capabilities.
Currently standalone DE is using fixed 2024-02-15-preview version,
the problem is when in-portal DE loads the databaseaccount from the portal with the latest API and passed into the DE, which breaks the contract for serverless accounts.

How Has This Been Tested?
Tested locally with sideloaded portal where the databaseaccount is fetched from 2024-05-15-preview API

@sunghyunkang1111 sunghyunkang1111 requested a review from a team as a code owner April 28, 2024 20:14
src/Common/Constants.ts Outdated Show resolved Hide resolved
src/Contracts/DataModels.ts Outdated Show resolved Hide resolved
@sunghyunkang1111 sunghyunkang1111 merged commit 4da3363 into master May 17, 2024
19 of 20 checks passed
@sunghyunkang1111 sunghyunkang1111 deleted the ARM_serverless branch May 17, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants