Suppress 403 when try getting access key #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw it only when necessary
vicancy
reviewed
May 17, 2024
src/Microsoft.Azure.SignalR.AspNet/Middleware/NegotiateMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Endpoints/AccessKeyForMicrosoftEntra.cs
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRAccessTokenNotAuthorizedException.cs
Outdated
Show resolved
Hide resolved
vicancy
reviewed
May 21, 2024
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRAccessTokenNotAuthorizedException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Exceptions/AzureSignalRAccessTokenNotAuthorizedException.cs
Outdated
Show resolved
Hide resolved
vwxyzh
reviewed
May 21, 2024
src/Microsoft.Azure.SignalR.Common/Endpoints/AccessKeyForMicrosoftEntra.cs
Outdated
Show resolved
Hide resolved
vicancy
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress 403 errors when try getting access key
The
ServiceManageris designed to try getting the access key even inTransientmode, as it may need to handle negotiate requests.However, considering some cases where the given
TokenCredentiallacks permission for theGetAccessKeyAPI, the error messages from failed attempts can be annoying. Therefore, we have chosen to suppress these errors and only throw the latest exception when necessary.Fixes #1913