Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Switch from ClientSecretCredential to DefaultAzureCredential #35651

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vincenttran-msft
Copy link
Member

This PR aims to move away from using discrete ClientSecretCredential for OAuth operations and to instead now use DefaultAzureCredential.

This also means that you have to routinely do az login when running OAuth tests to refresh your permission, but will get away from those pesky secrets 馃槃

TODO:

  • Get this passing in CI
  • Get this passing in live tests

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label May 15, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll keep an eye out for any usability quirks and make things more Storage setup-compatible if necessary.

@vincenttran-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants