[Event Hubs] Update URI used for consumer auth to include consumer group #35626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swathipil
requested review from
annatisch,
kashifkhan and
l0lawrence
as code owners
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
l0lawrence
reviewed
May 15, 2024
| @@ -191,6 +191,7 @@ def __init__( | |||
| network_tracing=network_tracing, | |||
| **kwargs, | |||
| ) | |||
| self._auth_uri = f"sb://{self._address.hostname}{self._address.path}/consumergroups/{self._consumer_group}" | |||
There was a problem hiding this comment.
2 thoughts - could we be resetting the path when we use $default, or do we not need to do this when not using RBAC?
There was a problem hiding this comment.
oo good thoughts - will check!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #35337
Currently, the URI used for authentication on the receiver only includes the EH namespace and hub. We should include the consumer group.
When consumer group is not included, we get an error when we try receiving with the
Event Hubs Data Receiverrole assigned to either the User/Service Principal at the consumer group level. To test assigning the role at the consumer group level, follow [these instructions]. (If testing on the Portal,consumergroups/<groupname>should be added to the end of the url after the hub name.)Tested locally for this scenario, which passes. Not adding a test, as it would require us to add the role using the azure-mgmt-authorization package, which we would have to add to the dev_requirements.txt.