Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a helper function to evaluate stringized annotations. (#35538) #35599

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Use a helper function to evaluate stringized annotations. (#35538) #35599

wants to merge 15 commits into from

Conversation

mchikyt3
Copy link

@mchikyt3 mchikyt3 commented May 13, 2024 •
edited

Description

This PR replaces the getattr(cls_or_func, "__annotations__", {}) in #L334 with a helper function typing.get_type_hints(cls_or_func, include_extras=True) to correctly evaluate the type back from its string form. The flag include_extras is set to True to correctly deal with the Annotated type. For Python version older than 3.9, typing.get_type_hints() doesn't have this flag.

It is a solution to (#35538).

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning labels May 13, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @mchikyt3! We will review the pull request and get back to you soon.

@mchikyt3
Copy link
Author

@microsoft-github-policy-service agree

@mchikyt3 mchikyt3 mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit singankit is a code owner

@diondrapeck diondrapeck Awaiting requested review from diondrapeck diondrapeck is a code owner

@luigiw luigiw Awaiting requested review from luigiw luigiw is a code owner

@kdestin kdestin Awaiting requested review from kdestin kdestin is a code owner

@MilesHolland MilesHolland Awaiting requested review from MilesHolland MilesHolland is a code owner

@needuv needuv Awaiting requested review from needuv needuv is a code owner

@ninghu ninghu Awaiting requested review from ninghu ninghu is a code owner

@YusakuNo1 YusakuNo1 Awaiting requested review from YusakuNo1 YusakuNo1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mchikyt3