[communication-chat] Data Loss Prevention and TextOnlyChat #29700
+1,448
−1,044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaLai
reviewed
May 14, 2024
sdk/communication/communication-chat/test/internal/utils/mockClient.ts
Outdated
Show resolved
Hide resolved
AmyL219
reviewed
May 14, 2024
| expectedIdentifier.communicationUser?.id, | ||
| ); | ||
| assert.deepEqual(responseMessagingPolicy, expectedMessagingPolicy); | ||
| assert.isTrue(responseMessagingPolicy?.textOnlyChat); |
There was a problem hiding this comment.
Is this textOnlyChat nullable? Could we test that scenario?
sdk/communication/communication-chat/test/internal/chatThreadClient.mocked.spec.ts
Show resolved
Hide resolved
sdk/communication/communication-chat/test/internal/utils/mockClient.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: AmyL219 <[email protected]>
Co-authored-by: AmyL219 <[email protected]>
JoshuaLai
requested review from
bterlson,
xirzec,
jeremymeng,
mpodwysocki,
maorleger and
LuChen-Microsoft
as code owners
JoshuaLai
requested review from
qiaozha,
MaryGao and
witemple-msft
as code owners
JoshuaLai
requested review from
anujissarMS,
minnieliu,
paolamvhz,
shwali-msft,
allchiang-msft,
whisper6284,
RoyHerrod,
danielav7,
marche0133,
yogeshmo,
akania,
jingjlii,
wanghoppe,
dpwatrous,
NickKouds,
joheredi and
timovv
as code owners
JoshuaLai
requested review from
joshfree,
pvaneck,
KevinBlasko,
scottaddie,
gracewilcox,
jairmyree and
Haiying-MSFT
JoshuaLai
approved these changes
Jun 5, 2024
|
/azp run js - communication - tests |
|
No pipelines are associated with this pull request. |
AmyL219
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists