Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query methods issue with no criteria bug fix for Spring JPA Keywords #40167

Merged
merged 3 commits into from
May 16, 2024

Conversation

trande4884
Copy link
Member

Description

Fixes bug #40092

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@trande4884 trande4884 changed the title Trande query methods no criteria bug fix Query methods issue with no criteria bug fix for Spring JPA Keywords May 15, 2024
@trande4884
Copy link
Member Author

/azp run java - spring - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884 trande4884 merged commit 3a3499b into Azure:main May 16, 2024
65 checks passed
trande4884 added a commit to trande4884/azure-sdk-for-java-trande that referenced this pull request May 16, 2024
…zure#40167)

* Fixing bug with the use of Spring Keywords that don't lead to a criteria being created.

* Update CosmosQuery.java
trande4884 added a commit that referenced this pull request May 16, 2024
#40204)

* Query methods issue with no criteria bug fix for Spring JPA Keywords (#40167)

* Fixing bug with the use of Spring Keywords that don't lead to a criteria being created.

* Update CosmosQuery.java

* Updating changelog. (#40206)

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] azure-spring-data-cosmos Query Methods always require Criteria inappropriately
4 participants