[azsystemevents] Changes to generate using typespec-go as the emitter, instead of autorest-go #22883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t very usable) generation. There's still some discussion about some ACS events where the example schema given and the actual swagger don't agree. Issue has been filed here: Azure#22903
richardpark-msft
force-pushed
the
eg-regen-05-02
branch
from
d9d6101
to
f3b3f00
Compare
|
There's enough here to review and commit, with two events that need a bit more work. That's been filed: #22903 |
richardpark-msft
added
the
Client
jhendrixMSFT
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a 1:1 change since the TypeSpec and the Swagger were being worked on independently.
I had to skip a couple of tests because the JSON sample given in the docs, the older JSON sample I copied over from .NET's tests, the swagger and now the TypeSpec don't agree.
Generally the teams appear to have taken a hands-off approach with the TypeSpec which means a lot of names have reverted back to their original names. All of those are documented in the CHANGELOG.
We're also using a beta emitter version, direct from GitHub, until we resolve which version we want to stamp as the first official NPM release.