Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct command for using specified openssl with cmake #5622

Merged
merged 1 commit into from
May 16, 2024

Conversation

ByteYue
Copy link
Contributor

@ByteYue ByteYue commented May 15, 2024

Pull Request Checklist

Hi there, I'm trying to integrate the Azure SDK into apache doris, and during the process, I found that I need to specify a particular version of OpenSSL. At this point, I discovered that the related commands in the documentation were incorrect, so I'm attempting to correct the documentation through this PR.

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 15, 2024
Copy link

Thank you for your contribution @ByteYue! We will review the pull request and get back to you soon.

@LarryOsterman
Copy link
Member

Thank you very much for catching my typo, the change looks good.

Let me know if you're done with verifying the fixes so I can merge the changes in.

README.md Show resolved Hide resolved
@ByteYue
Copy link
Contributor Author

ByteYue commented May 16, 2024

Thank you very much for catching my typo, the change looks good.

Let me know if you're done with verifying the fixes so I can merge the changes in.

Hi @LarryOsterman , sorry for my late response. I have already passed the verification, everything is fine now, and it’s ready to be merged.

@ahsonkhan ahsonkhan merged commit c95f74a into Azure:main May 16, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants