New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Center] azure-api-center-create #13985
Conversation
@dlepow - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@dlepow - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@mumian - FYI, this is a basic quickstart template for the API Center service, which will GA in early May. I plan to create ARM/bicep quickstarts around this. If you have suggestions for improving it, please let me know. Thanks! |
@dlepow - As you may already know, Bicep sits over ARM templates. All Bicep files undergo compilation into ARM templates before deployment. Creating Bicep files is considerably easier compared to crafting ARM templates. VSCode offers additional validation and intelligent features that simplify the creation of Bicep files. In the quickstart repository, you only need to provide a Bicep file, as the repository automatically generates an ARM template based on it. I've included the Bicep file for the template. To utilize the Bicep file, you'll need to rename the parameters in the parameter file and add some extra settings in the readme file. Please feel free to schedule a 30-minute session with me next week. I can guide you through the process of creating a Bicep file or converting an ARM template to a Bicep file. @description('Specifies the location for resources.') param apiCenterName string = 'apicenter${uniqueString(resourceGroup().id)}' @Allowed([ resource apiCenterService 'Microsoft.ApiCenter/services@2024-03-01' = { resource apiCenterWorkspace 'Microsoft.ApiCenter/services/workspaces@2024-03-01' = { resource api_center_name_default_api_name 'Microsoft.ApiCenter/services/workspaces/apis@2024-03-01' = { |
@mumian - thanks for the help here. I got the order wrong, clearly :). Before troubling you further, et me try updating first with a bicep file and resubmit. :) |
@dlepow - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#", | ||
"contentVersion": "1.0.0.0", | ||
"parameters": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra empty line. Also set tab=2 if it is possible.
@mumian - Fixed formatting. Thanks again for reviewing! |
@dlepow - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
Actually, please hold off til I retest. I've found some issues with the resource deployment. |
@@ -0,0 +1,43 @@ | |||
@description('Specifies the location for resources.') | |||
param location string = 'eastus' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change 'eastus' to resourceGroup().location.
@dlepow - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@dlepow - line 21 - The property "sku" does not exist in the resource or type definition. |
@dlepow - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
PR Checklist
Check these items before submitting a PR...
Contribution Guide
Best Practice Guide
Changelog