Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add system assigned template #13962

Merged
merged 1 commit into from May 3, 2024

Conversation

curiekim0
Copy link
Member

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@curiekim0 curiekim0 marked this pull request as ready for review April 26, 2024 19:15
@mvvsubbu
Copy link
Contributor

@curiekim0 can you check this PR and address the issues?

@curiekim0
Copy link
Member Author

curiekim0 commented Apr 30, 2024

@curiekim0 can you check this PR and address the issues?

Hello @mvvsubbu I have saw that the build failure was due to type warnings, some of which are carried over from the base template I used (the Vnet Inj Private Endpoint template), it didn't prevent the PR from being merged last time but let me take a look at them again to see if they can be resolved.

@alex-frankel alex-frankel merged commit 8c50b86 into Azure:master May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants