Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azuredeploy.json #13525

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Update azuredeploy.json #13525

merged 2 commits into from
Aug 23, 2023

Conversation

alexlzx
Copy link
Contributor

@alexlzx alexlzx commented Aug 16, 2023

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@azure-quickstarts azure-quickstarts added the remove azuredeploy.json bicep sample, remove json from PR label Aug 16, 2023
@azure-quickstarts
Copy link
Collaborator

@mamccrea - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

delete allowed values to avoid any confusion
@azure-quickstarts
Copy link
Collaborator

@mamccrea - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

@alexlzx
Copy link
Contributor Author

alexlzx commented Aug 23, 2023

@mamccrea Can you help us merge this pull request? Thanks

@anthony-c-martin anthony-c-martin merged commit 86c6008 into Azure:master Aug 23, 2023
3 checks passed
@alexlzx
Copy link
Contributor Author

alexlzx commented Aug 28, 2023

I don't see the update shown on the file. Can you please verify if my PR was merged successfully? azuredeploy.json

@anthony-c-martin
Copy link
Member

anthony-c-martin commented Aug 28, 2023

@alexlzx looks like this sample is generated from a .bicep file: https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.streamanalytics/streamanalytics-create/main.bicep

After your PR was merged, looks like our automation re-generated the azuredeploy.json file and overwrote your changes: 3dc1b4f

Sorry, I missed that when reviewing - I assumed automation in this repo would have blocked this scenario. I've raised #13534 to improve the automation.

To make the change successfully, you will need to edit the main.bicep file instead and submit a new PR for this. You don't need to include the changes to the azuredeploy.json file - they will be automatically made after your PR is merged.

@anboisve
Copy link

@anthony-c-martin

We have updated the main.bicep file and the json file has been updated -- however, the doc we are trying to update is still showing previous info: https://learn.microsoft.com/en-us/azure/stream-analytics/quick-create-azure-resource-manager#review-the-template

Please advise on next steps.

CC @alexlzx
CC @spelluru also if you can please help.

@anthony-c-martin
Copy link
Member

@anboisve you'd probably have to get in touch with the members of the MS Docs team who manage that page. My guess is that they're caching an old copy of the template, but I'm not sure what the process to update that cache would be (or if it'll just happen automatically).

It looks like @denrea modified this page most recently, and @mamccrea originally contributed it - they might know or be able to point you to someone who does.

@spelluru
Copy link
Contributor

@anthony-c-martin

That template is not hard-coded. It's showing the template from the following one. Looking at the quickstart template PR, that's the file which was updated.

:::code language="json" source="~/quickstart-templates/quickstarts/microsoft.streamanalytics/streamanalytics-create/azuredeploy.json":::

I have created a PR for the azure-docs-pr repo and verified that the new template shows up on staging. The PR is merged and we should see the updated template in the article after 10 AM PST publish today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remove azuredeploy.json bicep sample, remove json from PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants