Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Relic] Upgrade 2024-01-01 #24906

Draft
wants to merge 3 commits into
base: generation
Choose a base branch
from
Draft

Conversation

JoyerJin
Copy link
Contributor

Description

Upgrade version to 2024-01-01
Custom Monitor create cmdlet with RP get and register

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@JoyerJin JoyerJin requested a review from dolauli May 13, 2024 09:08
Copy link

azure-client-tools-bot-prd bot commented May 13, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
❌Az.NewRelic
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzNewRelicAccount Get-AzNewRelicAccount Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNewRelicAccount Get-AzNewRelicAccount changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNewRelicMonitor Get-AzNewRelicMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNewRelicMonitor Get-AzNewRelicMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNewRelicMonitoredSubscription Get-AzNewRelicMonitoredSubscription Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNewRelicMonitoredSubscription Get-AzNewRelicMonitoredSubscription changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNewRelicMonitorTagRule Get-AzNewRelicMonitorTagRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNewRelicMonitorTagRule Get-AzNewRelicMonitorTagRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNewRelicOrganization Get-AzNewRelicOrganization Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNewRelicOrganization Get-AzNewRelicOrganization changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNewRelicPlan Get-AzNewRelicPlan Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNewRelicPlan Get-AzNewRelicPlan changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzNewRelicFilteringTagObject New-AzNewRelicFilteringTagObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzNewRelicMonitoredSubscriptionObject New-AzNewRelicMonitoredSubscriptionObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
❌Help Example Check
❌PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzNewRelicMonitoredSubscriptionObject 1 1 Unassigned_Variable New-AzNewRelicMonitoredSubscriptionObject -LogRuleFilteringTag $includeFT is a null-valued parameter value. -LogRuleFilteringTag Assign value for $includeFT.
⚠️ New-AzNewRelicMonitoredSubscriptionObject 1 1 Unassigned_Variable New-AzNewRelicMonitoredSubscriptionObject -MetricRuleFilteringTag $includeFT is a null-valued parameter value. -MetricRuleFilteringTag Assign value for $includeFT.
Update-AzNewRelicMonitoredSubscription 1 3 Duplicate_Parameter_Name Update-AzNewRelicMonitoredSubscription -PatchOperation appeared more than once. -PatchOperation Remove redundant parameter -PatchOperation.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.NewRelic. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 61.54 % 88.24% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 61.54% 88.24% Test coverage cannot be lower than the number of the last release.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 61.54% 88.24% Test coverage cannot be lower than the number of the last release.

@YanaXu YanaXu marked this pull request as draft May 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant