-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1ES] Migrate Diagnostic Events to Azure.Data.Tables #10167
base: dev
Are you sure you want to change the base?
Conversation
e5eda2c
to
bde1976
Compare
src/WebJobs.Script.WebHost/Diagnostics/DiagnosticEventTableStorageRepository.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Diagnostics/DiagnosticEventTableStorageRepository.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Viau <[email protected]>
This reverts commit 21588fd.
deps.json unit test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just @brettsam's comment regarding checking table exists before creation to minimize telemetry. Also wondering when we can remove the deprecated Microsoft.Azure.Cosmos.Table
package.
The Azure.Data.Tables SDK after 12.7.0 seems to have that issue resolved. I'm double checking that's actually the case: Azure/azure-sdk-for-net#30849 |
This PR migrates the Diagnostic Events to use Azure.Data.Tables from Microsoft.Azure.Cosmos.Table
resolves #10165
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md