Delegate parsing of targetFramework to dotnet CLI #3604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Instead of parsing the .csproj file, determine the target framework by calling
dotnet build -getproperty:TargetFramework
.It "works on my machine" (OSX, dotnet 8.0.201). I'm not aware if this solution has portability issues.
resolves #3565
Alternatives considered
I tried using
new Project(path)
instead ofProjectRootElement.Open(path)
in hopes thatnew Project
would find and import any external properties.It didn't run. My .csproj file starts with
<Project Sdk="Microsoft.NET.Sdk">
, and callingnew Project(csproj_content)
throws exceptionThe SDK 'Microsoft.NET.Sdk' specified could not be found
.Pull request checklist