-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{IoT} Fix DPS policy key regeneration when setting empty strings as keys #28955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o service This will cause the service to regenerate those keys for that policy
️✔️AzureCLI-FullTest
|
Hi @c-ryan-k, |
️✔️AzureCLI-BreakingChangeTest
|
IoT |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
May 13, 2024 17:40
digimaun
reviewed
May 14, 2024
digimaun
reviewed
May 15, 2024
vilit1
reviewed
May 15, 2024
digimaun
approved these changes
May 16, 2024
Hi @c-ryan-k |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az iot dps policy update
Description
Currently the service rejects empty key values of
""
as invalid input, this sends the correctNone
/null
values to the service for these values and will successfully regenerate keys for that policy.Testing Guide
Force service to regenerate primary key:
az iot dps policy update -g {group} --dps-name {dps} --pn {policy} --primary-key ""
Force service to regenerate secondary key:
az iot dps policy update -g {group} --dps-name {dps} --pn {policy} --secondary-key ""
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.