[Core] BREAKING CHANGE: az extension add/update and az upgrade: Set default --allow-preview value from True to be False
#28913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllyW
requested review from
jiasli,
zhoxing-ms,
evelyn-ys,
jsntcy and
kairu-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @AllyW, |
️✔️AzureCLI-BreakingChangeTest
|
|
Core |
microsoft-github-policy-service
bot
added
Auto-Assign
AllyW
changed the title
--allow-preview value from True to be False for az extension add/update and az upgrade --allow-preview value from True to be False for az extension add/update and az upgrade
AllyW
modified the milestones:
June 2024 (2024-07-02),
May 2024 (2024-05-21)❗ Breaking change release ❗
AllyW
requested review from
wangzelin007,
yanzhudd,
calvinhzy and
necusjz
as code owners
bebound
reviewed
May 8, 2024
| @@ -34,7 +34,7 @@ for ext in $output; do | |||
| fi | |||
|
|
|||
| echo "Verifying extension:" $ext | |||
| az extension add -n $ext | |||
| az extension add -n $ext --allow-preview True | |||
There was a problem hiding this comment.
How many extensions do not follow the latest version number convention?
The test script should use the default config, as most users do.
There was a problem hiding this comment.
The latest version schema and cli core code is compatible with the version number of all extension modules.
There are 94 extension modules that only has preview releases (which would be failed when customers use new cli to install extension, and if it fails, the message like following will be prompted to users.)
There was a problem hiding this comment.
This's a huge number.
Lots of users will be affected.
|
The PR title does not follow the convention. We need to put command name at the beginning of the title. |
kairu-ms
reviewed
May 8, 2024
kairu-ms
previously approved these changes
May 8, 2024
AllyW
changed the title
--allow-preview value from True to be False for az extension add/update and az upgrade az extension add/update and az upgrade: Set default --allow-preview value from True to be False
|
After cli released, customers will get error message as below for extension modules which do not have stable versions. |
AllyW
force-pushed
the
extension-stable-default
branch
from
c039d60
to
d29fc7d
Compare
AllyW
modified the milestones:
May 2024 (2024-05-21)❗ Breaking change release ❗,
Backlog
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Extension] BREAKING CHANGE:
az extension add/update: Set default--allow-previewvalue fromTrueto beFalse[Upgrade] BREAKING CHANGE:
az upgrade: Set default--allow-previewvalue fromTrueto beFalseThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.