Change validation for sqlvm Entra authentication #28912
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @veppala, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan,
evelyn-ys and
calvinhzy
|
Please fix CI issues first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sql vm validate-azure-ad-auth
az sql vm enable-azure-ad-auth
Description
Entra authentication can only be enabled for SQL2022
CLI validates entra auth requests by getting SQL version from SqlImageOffer and checks if the version is SQL2022. But SqlImageOffer is set only once during registration and is not updated when SQL version is changed. As a result, any customer who had previous SQL version and upgraded to SQL2022 will still not be able to configure entra auth.
To avoid this, removing the validation SQL version and rely on the server-side validation that always happens.
Todo: we need to use extension status file (RPPluginStatus.SQLVersion) to get the SQL version.
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.