Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dapr PubSub template for Java applications on AKS and fix diagram… #155

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

greenie-msft
Copy link

@greenie-msft greenie-msft commented Jun 6, 2023

…s for other Dapr templates

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

…s for other Dapr templates

Signed-off-by: Nick Greenfield <[email protected]>
Signed-off-by: Nick Greenfield <[email protected]>
1 - Dapr Albums in ACA
6 - Functions with AI

Signed-off-by: Nick Greenfield <[email protected]>
Signed-off-by: Nick Greenfield <[email protected]>
@hemarina
Copy link
Contributor

hemarina commented Jun 8, 2023

@v-xuto Could you validate and test these templates when you get a chance?

cc @rajeshkamal5050 @jongio

@v-xuto
Copy link
Member

v-xuto commented Jun 9, 2023

@v-xuto Could you validate and test these templates when you get a chance?

cc @rajeshkamal5050 @jongio

Sure, we will start testing these templates.

@jongio
Copy link
Member

jongio commented Jun 15, 2023

@greenie-msft - I see OPENAI_API_KEY in the readme, but I don't see it in bicep. https://github.com/Azure-Samples/function-csharp-ai-openai-chatgpt

Could you look into using azd env set OPENAI_API_KEY value, and then, read that value into main.parameter.json and then use it in your infra.

@savannahostrowski savannahostrowski requested review from savannahostrowski and removed request for savannahostrowski August 3, 2023 17:37
@v-xuto
Copy link
Member

v-xuto commented Sep 5, 2023

@hemarina
Copy link
Contributor

hemarina commented Nov 8, 2023

@macromania
Copy link

Hi @hemarina & @greenie-msft,

This issue Azure-Samples/pubsub-dapr-aks-java#1 is now fixed. Hopefully the template can make into here. 😅 Please let me know if you'd require anything further.

Also, apologies for the delay 😇

remove templates that passed the tests as they are added in PR 257
@hemarina
Copy link
Contributor

hemarina commented Nov 29, 2023

@greenie-msft All other templates that passed the test were merged in PR #257. Please take a look at issues in function-csharp-ai-openai-chatgpt and containerapps-dapralbums. function-csharp-ai-textsummarize issues are not blocking as the template is already in gallery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants