Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAF compliancy patch for adding DDoS protection plan #605

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yahanda
Copy link
Contributor

@yahanda yahanda commented Apr 11, 2024

Overview/Summary

Adding DDoS network protection option to be completely WAF compliant as per ADO Items below:
https://dev.azure.com/CSUSolEng/Accelerator%20-%20AVD/_workitems/edit/34480/
https://dev.azure.com/CSUSolEng/Accelerator%20-%20AVD/_workitems/edit/34047/

This PR fixes/adds/changes/removes

  1. The DDoS network protection is not enabled by default. We can include in the accelerator the option to enable DDoS protection on the Vnet.

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

Tested from the link below
https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fwaf-compliancy-patch-3%2Fworkload%2Farm%2Fdeploy-baseline.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fwaf-compliancy-patch-3%2Fworkload%2Fportal-ui%2Fportal-ui-baseline.json

Added checkbox for DDoS network protection
image

Deployed successfully
image

Successfully added DDoS protection plan on vnet
image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant