US 30535 - Terraform - FSLogix with ADDS v2 #429 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Talked to @danycontre and I added a feature to run custom script "Set-SessionHostConfiguration.ps1" in order to configure fslogix on for every host. 
|
|
@jensheerin checking with you on this one. |
|
do not merge until review is completed. |
jensheerin
reviewed
Feb 9, 2024
| } | ||
| time = { | ||
| source = "hashicorp/time" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| provider "azuread" { | ||
| tenant_id = "b7b812fe-be8c-4adc-883f-2a3c36d753d7" |
There was a problem hiding this comment.
The tenant_id needs to be removed, it is not needed here.
jensheerin
reviewed
Feb 9, 2024
| ou_for_fslogix_storage = "OU=AvdStorage,DC=avd,DC=local" # If you want to use a different OU for FSLogix storage | ||
| ou_name_for_fslogix_storage = "AvdStorage" # Name of the OU for FSLogix storage | ||
|
|
||
|
|
||
| ############## Do not modify below this line unless you want to change naming convention##################### | ||
| # Resource Groups |
There was a problem hiding this comment.
line 16 should be ou_for_session_hosts
|
also run fmt |
|
@jensheerin I've done the requested adjustments, please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Adds the Management VM module to Terraform, including joining the storage account to the domain and a user assigned managed identity.
This PR fixes/adds/changes/removes
Testing Evidence
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch