Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lib): remove winston dependency #4705

Merged
merged 3 commits into from
May 17, 2024
Merged

refactor(lib): remove winston dependency #4705

merged 3 commits into from
May 17, 2024

Conversation

archerzz
Copy link
Member

Description

this is a backport of microsoft/typespec#3343

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

ArcturusZhang
ArcturusZhang reviewed May 14, 2024
View reviewed changes
eng/Generation.psm1 Outdated Show resolved Hide resolved
@archerzz @ArcturusZhang
Update eng/Generation.psm1
433243f 
Co-authored-by: Dapeng Zhang <[email protected]>
@archerzz archerzz merged commit 0fb10e0 into Azure:feature/v3 May 17, 2024
8 checks passed
@archerzz archerzz deleted the lib/remove-winston branch May 17, 2024 04:04
@archerzz archerzz mentioned this pull request May 23, 2024
Closed
archerzz added a commit to archerzz/autorest.csharp that referenced this pull request May 23, 2024
@archerzz
fix(emitter): wrong package name in trace logs
2607793 
fix a regression when back porting changes from `microsoft/typespec` in pr: Azure#4705

fix Azure#4751
@archerzz archerzz mentioned this pull request May 23, 2024
Merged
6 tasks
archerzz added a commit that referenced this pull request May 23, 2024
@archerzz
fix(emitter): wrong package name in trace logs (#4753)
59ec789 
* fix(emitter): wrong package name in trace logs

fix a regression when back porting changes from `microsoft/typespec` in pr: #4705

fix #4751

* update trace name

* refactor to consolidate package name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang left review comments

@lirenhe lirenhe lirenhe approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@archerzz @lirenhe @ArcturusZhang