Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the workaround introduced in previous PR for format decorator #4689

Merged

Conversation

ArcturusZhang
Copy link
Member

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang marked this pull request as ready for review May 14, 2024 06:11
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double confirm: from now on, we'll not support @format decorator values like uri which already have corresponding types defined, right?

@ArcturusZhang
Copy link
Member Author

just double confirm: from now on, we'll not support @format decorator values like uri which already have corresponding types defined, right?

yes, and supported formats are supported in TCGC, we just take whatever types TCGC gives us

@ArcturusZhang ArcturusZhang merged commit 1d425ad into Azure:feature/v3 May 17, 2024
8 checks passed
@ArcturusZhang ArcturusZhang deleted the remove-format-getAllModels branch May 17, 2024 09:01
ArcturusZhang added a commit to ArcturusZhang/typespec that referenced this pull request May 29, 2024
ArcturusZhang added a commit to ArcturusZhang/typespec that referenced this pull request May 29, 2024
ArcturusZhang added a commit to ArcturusZhang/typespec that referenced this pull request May 29, 2024
ArcturusZhang added a commit to ArcturusZhang/typespec that referenced this pull request May 29, 2024
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request May 29, 2024
joheredi pushed a commit to joheredi/typespec that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants