Move some more helpers from shared code to generated helpers #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
commented
Apr 30, 2024
| @@ -28,9 +27,10 @@ namespace AutoRest.CSharp.Generation.Writers | |||
| { | |||
| internal static class RequestWriterHelpers | |||
| { | |||
| public static void WriteRequestAndUriCreation(CodeWriter writer, RestClientMethod clientMethod, string methodAccessibility, ClientFields fields, string? responseClassifierType, bool writeSDKUserAgent, IReadOnlyList<Parameter>? clientParameters = null) | |||
| // This only serves the MPG now | |||
| public static void WriteRequestAndUriCreation(CodeWriter writer, RestClientMethod clientMethod, ClientFields fields, string? responseClassifierType, bool writeSDKUserAgent, IReadOnlyList<Parameter>? clientParameters = null) | |||
There was a problem hiding this comment.
removed this methodAccessibility parameter because in everywhere it is getting invoked, we are always passing in internal.
ArcturusZhang
commented
Apr 30, 2024
| @@ -72,7 +72,7 @@ public static IEnumerable<MethodBodyStatement> BuildMultipartSerializationMethod | |||
| /*return BinaryData.FromStream(stream);*/ | |||
| Return(BinaryDataExpression.FromStream(stream, false)), | |||
| /*return new BinaryData(stream.GetBuffer().AsMemory(0, (int)stream.Position));*/ | |||
| Return(New.Instance(typeof(BinaryData), new[]{ new InvokeInstanceMethodExpression((new StreamExpression(stream)).GetBuffer, "AsMemory", new[] { Literal(0), new CastExpression(stream.Property("Position"), typeof(int)) }, null, false) })) | |||
| Return(New.Instance(typeof(BinaryData), new[]{ new InvokeInstanceMethodExpression(new StreamExpression(stream).GetBuffer(), "AsMemory", new[] { Literal(0), new CastExpression(stream.Property("Position"), typeof(int)) }, null, false) })) | |||
There was a problem hiding this comment.
The GetBuffer on Stream class is a method, therefore our expression should express it as a method even if it takes no arguments.
ArcturusZhang
commented
Apr 30, 2024
| @@ -457,7 +457,7 @@ private static ValueExpression DeserializeValue(XmlValueSerialization serializat | |||
|
|
|||
| if (frameworkType == typeof(object)) | |||
| { | |||
| return element.GetObjectValue(serialization.Format.ToFormatSpecifier()); | |||
| return element.Value; | |||
There was a problem hiding this comment.
in the extension, the XElement.GetObjectValue method is just calling element.Value, therefore we just remove it to call this directly
ArcturusZhang
force-pushed
the
add-other-helpers-for-azure-libraries
branch
3 times, most recently
from
cfde916
to
cfa16cb
Compare
ArcturusZhang
force-pushed
the
add-other-helpers-for-azure-libraries
branch
from
cfa16cb
to
b0260d3
Compare
ArcturusZhang
force-pushed
the
add-other-helpers-for-azure-libraries
branch
2 times, most recently
from
5d9e020
to
46c7a81
Compare
ArcturusZhang
force-pushed
the
add-other-helpers-for-azure-libraries
branch
from
46c7a81
to
65402be
Compare
ArcturusZhang
force-pushed
the
add-other-helpers-for-azure-libraries
branch
from
ca93a0d
to
a827900
Compare
ArcturusZhang
force-pushed
the
add-other-helpers-for-azure-libraries
branch
from
a827900
to
4871229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here!
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?