[experiment][dpg] do not convert enum client parameters into string #4457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In DPG, we use
InputModelTypeUsage.None
as a tricky way to convert enum client parameters into string.autorest.csharp/src/AutoRest.CSharp/LowLevel/AutoRest/DpgOutputLibrary.cs
Lines 123 to 126 in 23dcd81
This won't work when adopting TCGC because TCGC will give a
InputModelTypeUsage.Input
for client parameters. Then enum client parameters will still be enum, which will cause exception when trying to get Field from parameter (which is enum value type):autorest.csharp/src/AutoRest.CSharp/Common/Output/Models/ClientFields.cs
Line 131 in 23dcd81
This PR investigate one solution to resolve this problem. It will change the logic of finding matching field. For enum field type, we'll try to match its value type as well. If that matches, then we'll return that field.
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?