Mgmt schema consolidation #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…06/autorest.csharp into mgmt-schema-consolidation
m-nash
reviewed
May 20, 2024
src/AutoRest.CSharp/Common/Input/InputTypes/Examples/InputOperationExample.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Input/InputTypes/InputModelProperty.cs
Outdated
Show resolved
Hide resolved
live1206
commented
May 21, 2024
live1206
commented
May 21, 2024
live1206
commented
May 21, 2024
Yes. With swagger input, we have There are some minor diffs, which I think are acceptable: |
…06/autorest.csharp into mgmt-schema-consolidation
…06/autorest.csharp into mgmt-schema-consolidation
This was referenced May 22, 2024
Closed
Remove AllBaseModels and ImmediateBaseModels
m-nash
approved these changes
May 29, 2024
| @@ -523,18 +464,15 @@ protected override IEnumerable<ObjectTypeProperty> BuildProperties() | |||
| var propertiesFromSpec = GetParentPropertyDeclarationNames(); | |||
| var existingProperties = GetParentPropertySerializedNames(); | |||
|
|
|||
| foreach (var objectSchema in GetCombinedSchemas()) | |||
| foreach (var property in UpdateInputModelProperties()) | |||
There was a problem hiding this comment.
well I have some questions on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate
CodeModel.SchemaintoInputType