Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorityClassName to Helm Charts - Issue #1143 #1144

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aglees
Copy link

@aglees aglees commented Feb 17, 2021

Checklist

  • The title of the PR is clear and informative
  • If applicable, the changes made in the PR have proper test coverage
  • Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

Add an option in the Helm Chart for priorityClassName

Fixes

This addresses the feature request #1143

@ghost
Copy link

ghost commented Feb 17, 2021

CLA assistant check
All CLA requirements met.

@akshaysngupta
Copy link
Member

akshaysngupta commented Mar 23, 2021

@aglees can you add a helm render test.

  1. Update this file with the new parameter.
  2. Set env variable export RENDER_SNAPSHOTS="true"
  3. You can then check by running go test ./... in the folder.
  4. Check and Commit the snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants