Add some development options to SQL metastore #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est server and a soft delete option that can be used to debug gc pproblems
blueww
reviewed
Oct 25, 2023
| @@ -365,8 +367,12 @@ export default class SqlBlobMetadataStore implements IBlobMetadataStore { | |||
| } | |||
| ); | |||
|
|
|||
| // TODO: sync() is only for development purpose, use migration for production | |||
| await this.sequelize.sync(); | |||
| if (this.clearDB) { | |||
There was a problem hiding this comment.
Blob content is on local disk, so clear DB will make data not aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some development/debugging options to SQL metastore:
cleardbthat clear the database at start which is only set to true in test serversoft deleteoption that can be used to debug GC problems