-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy Baseline Exemption Logic Needs to Live in ALZ Repo and a Flag for Azure Firewall Policy #762
Conversation
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VeronicaSea, thanks for submitting this PR, let me know if you have any questions as you're going over my comments.
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
Hey @VeronicaSea, feel free to just ping me when you ready for me to re-review. Have a good week! |
Yes, it is ready for your review. Please review it and thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @VeronicaSea, along with the changes I suggested and/or requested. Could we also ensure that the exemptions module folder contains all of the files documented here: https://github.com/Azure/ALZ-Bicep/wiki/Contributing#constructing-a-bicep-module.
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/exemptions/policyExemptions.bicep
Outdated
Show resolved
Hide resolved
…DefaultPolicyAssignments.bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
….bicep Co-authored-by: Zach Trocinski <[email protected]>
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview/Summary
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch