This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Added aria-describedby atttribute to avfield to link error messages #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/AvField.js
Outdated
| @@ -89,14 +89,14 @@ export default class AvField extends Component { | |||
| size={size} | |||
| disabled={disabled} | |||
| readOnly={readOnly} | |||
| {...attributes} | |||
| {...{...attributes, ...{'aria-describedby':'errorMsg'}}} | |||
There was a problem hiding this comment.
I think we should change this to
aria-describedby="errorMsg"
{ ...attributes }
This way the user can override it if needed
src/AvField.js
Outdated
| > | ||
| {children} | ||
| </AvInput>); | ||
|
|
||
| const validation = this.context.FormCtrl.getInputState(this.props.name); | ||
|
|
||
| const feedback = validation.errorMessage ? (<AvFeedback>{validation.errorMessage}</AvFeedback>) : null; | ||
| const feedback = validation.errorMessage ? (<AvFeedback id="errorMsg">{validation.errorMessage}</AvFeedback>) : null; |
There was a problem hiding this comment.
We should make the id dynamic. If multiple fields have an error, then there will be more than one element with id="errorMsg".
We can generate it off the id for the field
<AvFeedback id={`${id}-error`} ...`
we should use this value with the aria-describedby prop as well
src/AvField.js
Outdated
| @@ -89,14 +89,15 @@ export default class AvField extends Component { | |||
| size={size} | |||
| disabled={disabled} | |||
| readOnly={readOnly} | |||
| aria-describedby = {`${id}-error`} | |||
There was a problem hiding this comment.
Let's also make this conditional using the same logic for AvFeedback. We don't want to point to an element that doesn't exist.
Also, please remove the spaces around the = to match the other props.
jordan-a-young
approved these changes
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.