Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#453 add width to input control element #1085

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

chialiotta
Copy link

@chialiotta chialiotta commented Apr 3, 2024

Issue #453

from taipy.gui import Gui, State

bval = True
user_prompt_1 = "Enter your name"
user_prompt_2 = "Enter your message"

md = """

<|{user_prompt_1}|input|width={500}|>
<|{user_prompt_2}|input|width=70%|>

"""

Gui(md).run()

@chialiotta chialiotta changed the title add width to input control element Feature/#453 add width to input control element Apr 3, 2024
@FlorianJacta FlorianJacta added 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 🟩 Priority: Low Low priority and doesn't need to be rushed labels Apr 17, 2024
@FlorianJacta
Copy link
Member

Thank you @chialiotta, we are looking into this

@trgiangdo trgiangdo linked an issue May 21, 2024 that may be closed by this pull request
3 tasks
@jrobinAV
Copy link
Member

@dinhlongviolin1 @FabienLelaquais @FredLL-Avaiga
Please review the PR so the bot does not unassign it.

multiline={multiline}
minRows={linesShown}
/>
<Box width={width} data-testid="textfield-box">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're changing the display mode of the input.
Box is a div => display: block
We want the display to be more like a span (ie inline)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure anymore of what it would render
@chialiotta Could you copy here a screenshot of a page with 2 input side by side ?
ie <|{user_prompt_1}|input|width={500}|><|{user_prompt_2}|input|width=50%|> ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It is indeed not inline, I will change it. It might take me a few days to get to it though because I'm busy with my thesis, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add width property to input control
4 participants