Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automattic for Agencies: Redesign hosting marketplace page #90837

Merged
merged 3 commits into from
May 20, 2024

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented May 17, 2024

Resolves https://github.com/Automattic/jetpack-roadmap/issues/1563

Proposed Changes

This PR redesigns the hosting marketplace page

Testing Instructions

  1. Open the A4A live link.
  2. Visit the Marketplace > Hosting page and verify the UI is redesigned as shown below and matches with the latest design (link on the ticket). Also, verify it works well on the screen sizes.

screencapture-agencies-localhost-3000-marketplace-hosting-2024-05-20-17_22_42

Screenshot 2024-05-20 at 5 25 11 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested review from jeffgolenski, keoshi and a team May 17, 2024 07:35
@yashwin yashwin self-assigned this May 17, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 17, 2024
@matticbot
Copy link
Contributor

matticbot commented May 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1478 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace      +3938 B  (+0.7%)    +1431 B  (+0.8%)
settings-performance                +13 B  (+0.0%)      +47 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great, except for mobile. It doesn't seem to show the tooltip on tap.

Would it be possible to add that?

image

Thank you!

@yashwin yashwin force-pushed the update/a4a/hosting-page-redesign branch from d1033e0 to d7e3640 Compare May 17, 2024 09:21
@yashwin
Copy link
Contributor Author

yashwin commented May 17, 2024

Thanks for the review, @keoshi!

Looks and works great, except for mobile. It doesn't seem to show the tooltip on tap.
Would it be possible to add that?

Yes, I added an onTouchStart event that should handle this.

Screen.Recording.2024-05-17.at.2.51.50.PM.mov

@yashwin yashwin requested a review from keoshi May 17, 2024 09:26
@jkguidaven
Copy link
Contributor

The Migration offer card seems way too close to the hosting cards.

Screenshot 2024-05-17 at 7 21 54 PM

From Design
Screenshot 2024-05-17 at 7 23 19 PM

@jkguidaven
Copy link
Contributor

jkguidaven commented May 17, 2024

I also noticed that the border-radius on the new design uses 8px. @keoshi is this correct?

https://www.figma.com/design/sX0uNGAgDUceP3nKu7iQ4z/Purchase-flows?node-id=5694-25942&t=gQmtAgaueRhrl3oA-0

Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Works great. I left few comments though.

client/a8c-for-agencies/style.scss Outdated Show resolved Hide resolved
client/a8c-for-agencies/style.scss Outdated Show resolved Hide resolved
@yashwin
Copy link
Contributor Author

yashwin commented May 17, 2024

Thanks for the review, @jkguidaven!

I have addressed your comments: 27fb2ce

Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this LGTM. Changes also works great as per test instructions. 👍

Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, Yashwin! Have two small comments that are non-blocking, so I'm approving the PR.

Doesn't respond to simple tap

On mobile, it seems like the tooltip is only shown when tap + moving the tap point is involved. In other others, it doesn't seem to respond to a simple tap on the same spot.

I'm testing this in the laptop, simulating a touch device, so it might be that causing the issue. If we can't fix it on mobile, it might be worth to always display the tooltip on touch devices.

Shared benefit should be full-width

According to the latest designs by @jeffgolenskihttps://www.figma.com/design/sX0uNGAgDUceP3nKu7iQ4z/Purchase-flows?node-id=8346-138635&t=X10Un6R2s1Trcn6F-11 — the bottom section that groups shared benefits should be full-width.

Also notice the title should be "Included with Standard & Premier hosting".

image

Thanks for all your hard work on this, @yashwin !

@yashwin yashwin force-pushed the update/a4a/hosting-page-redesign branch 2 times, most recently from 9c834bd to d064632 Compare May 20, 2024 11:41
@yashwin yashwin force-pushed the update/a4a/hosting-page-redesign branch from d064632 to 34f430d Compare May 20, 2024 11:47
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/a4a/hosting-page-redesign on your sandbox.

@yashwin
Copy link
Contributor Author

yashwin commented May 20, 2024

Thanks for the review, @keoshi!

Doesn't respond to simple tap

I think this should work on mobile devices. I'll do a round of testing on mobile once this PR is shipped and fix it if needed in another PR.

Shared benefit should be full-width

According to the latest designs by @jeffgolenskihttps://www.figma.com/design/sX0uNGAgDUceP3nKu7iQ4z/Purchase-flows?node-id=8346-138635&t=X10Un6R2s1Trcn6F-11 — the bottom section that groups shared benefits should be full-width.

Thanks for linking the latest design.

Also notice the title should be "Included with Standard & Premier hosting".

I have updated it now, including some text changes: 34f430d

screencapture-agencies-localhost-3000-marketplace-hosting-2024-05-20-17_22_42

@keoshi
Copy link
Contributor

keoshi commented May 20, 2024

Perrrfect — ship it! 🚢

@yashwin yashwin added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 20, 2024
@yashwin yashwin removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 20, 2024
@yashwin yashwin merged commit 9eca52b into trunk May 20, 2024
13 checks passed
@yashwin yashwin deleted the update/a4a/hosting-page-redesign branch May 20, 2024 13:48
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 20, 2024
@simonktnga8c
Copy link

Can we pause on shipping this one @yashwin please, sorry if it's a pain.

@simonktnga8c
Copy link

Want to get the final go-ahead from leadership before we do.

@simonktnga8c
Copy link

Thanks for reverting 👍 seeking clarity from leadership now. I'll let you know as soon as I do.

yashwin added a commit that referenced this pull request May 20, 2024
@yashwin
Copy link
Contributor Author

yashwin commented May 20, 2024

@simonktnga8c: Sure, I have shipped the revert PR and created a new one now: #90890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants