Jetpack Backup: Redirect back to main backup page when clicking on Back up now button

[Initsogar]

Resolves https://github.com/Automattic/jetpack-backup-team/issues/482

Proposed Changes

• Add a custom onClick handler on BackupNowButton, that will give us more flexibility on adding custom logic when clicking that button.
• Redirect to the main backup page when clicking on Back up now button, so the user can monitor the progress of the backup being created

Why are these changes being made?

• Currently, if the user clicks on Back up now, it indicates their interest in securing their latest changes. Therefore, we want to ensure they can monitor the progress of the backup being created.

Testing Instructions

• Spin up a Calypso Blue or Jetpack Cloud live branch
• Pick a site with Jetpack VaultPress Backup plan with more than 1 backup
• Navigate to the backup page
• Pick a date on the calendar rather than Today
• Click on Back up now
• You should be redirected back to Today and you should see the progress of the backup being created.

To validate how it was working before, you can try the same steps in production.

Demo

CleanShot.2024-05-16.at.22.32.00.mp4

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108156

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108156&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108156&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~0 bytes added 📈 [gzipped])

name                           parsed_size           gzip_size
jetpack-cloud-agency-sites-v2        -59 B  (-0.0%)       +0 B
backup                               -59 B  (-0.0%)       +0 B
a8c-for-agencies-sites               -59 B  (-0.0%)       +0 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[Initsogar]

This comment is no longer necessary.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/on-demand-backup-redirect on your sandbox.

[mavegaf]

Tested with Calypso and with Jetpack Cloud. It seems it only works in Jetpack Cloud, Is that expected

[Initsogar]

Tested with Calypso and with Jetpack Cloud. It seems it only works in Jetpack Cloud, Is that expected

@mavegaf Hmm, it should work on both. I'll take a look. Thanks!

[Initsogar]

Tested with Calypso and with Jetpack Cloud. It seems it only works in Jetpack Cloud, Is that expected

@mavegaf fixed! I did forget that we were rendering only the BackupNowButton directly when the user is navigating on Calypso Blue. So I refactored the BackupActionsToolbar in a way that we could use that component for both cases, and inside we decide if we need to display or not the Copy site button.

Could you take another look? :)

[mavegaf]

Tested in both, no errors in console 👍