Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import-hosted-site reference from /start/hosting to new flow #90814

Merged
merged 1 commit into from
May 20, 2024

Conversation

andres-blanco
Copy link
Contributor

@andres-blanco andres-blanco commented May 16, 2024

Closes #90648

Proposed Changes

While this shouldn't be merged because of missing pieces in the flow (mainly #90710) I was exploring some code and made this changes to test.

Why are these changes being made?

To point /start/hosting to a Migrate Guru flow

Testing Instructions

  • Apply this patch or follow the calypso.live link
  • Go to /start/hosting
  • Select Migrate Site
  • Verify you get redirected to /setup/hosted-site-migration/site-migration-identify

Tracking

To track the performance of this link, the calypso_signup_actions_submit_step track event with these props:

  • step: hosting-decider
  • stepper_hosting_flow: hosted-site-migration

can be used as a starting point for the funnels.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andres-blanco andres-blanco requested a review from a team May 16, 2024 18:55
@andres-blanco andres-blanco self-assigned this May 16, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 16, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@andres-blanco andres-blanco force-pushed the add/move-to-migrate-guru-start-hosting branch from a94fd1d to 965bae0 Compare May 20, 2024 16:07
@andres-blanco andres-blanco changed the title [DO NOT MERGE] Update import-hosted-site reference from /start/hosting to new flow Update import-hosted-site reference from /start/hosting to new flow May 20, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/move-to-migrate-guru-start-hosting on your sandbox.

Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me!

@andres-blanco andres-blanco merged commit 00d77c0 into trunk May 20, 2024
12 checks passed
@andres-blanco andres-blanco deleted the add/move-to-migrate-guru-start-hosting branch May 20, 2024 19:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Migration: Update import-hosted-site reference from wordpress.com/start/hosting
3 participants