-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription overlay: adjustments to group layout #37435
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
align-items: center; | ||
flex-direction: column; | ||
justify-content: center; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to get this work without these CSSes. :-/
Not sure if it's my theme, or something else, but they don't appear in the styles like I'd expect based on settings and them modal looks broken without.
width: 100%; | ||
max-width: 400px; | ||
/*max-width: 400px;*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to get this content width happen via blocks directly; I get it's important to have or otherwise long texts look weird on wide modal.
transition: top 0.4s, visibility 0.4s; | ||
text-wrap: pretty; | ||
} | ||
|
||
/* These should be coming from the editor :-( */ | ||
.jetpack-subscribe-overlay__content .wp-block-group.is-layout-flex { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we keep it (still prefer not), we need to make sure it's applied only to top-most group, perhaps by giving the group block a custom CSS class.
It's good to have jetpack-subscribe-overlay__content
so that everything still works even if they remove the group block in the template accidentally.
@@ -39,6 +46,7 @@ body.jetpack-subscribe-overlay-open { | |||
right: 32px; | |||
width: 24px; | |||
height: 24px; | |||
z-index: 50001; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use text-color CSS var selector here? Or move the close button to the template directly?
Testing moving styling into the editor more from fixed CSS:
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: