-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavEKF3_core::setup_core: is beacon buffer length setted wrong? #26833
Comments
Hi @luweiagi, Thanks for your ongoing bug search, it's very much appreciated. I think we support multiple beacons that could theoretically each provide an update at a high rate, but I'm also pretty sure that we don't allow the total number of updates from all beacons to be more than 50hz (total, e.g. if 5 beacons then each can only update at 10hz maximum) so I agree that it is probably fine to reduce the size of the rngBcn.storedRange array to be smaller. On the other hand, do we really want to risk making it smaller just to save a few bytes of RAM? |
@rmackay9 |
Here we set beacon buffer length as imu_buffer_length+1:
ardupilot/libraries/AP_NavEKF3/AP_NavEKF3_core.cpp
Line 140 in d0a7e70
But, at
ardupilot/libraries/AP_NavEKF3/AP_NavEKF3_core.cpp
Line 96 in d0a7e70
We said that obs_buffer_length should not longer than the IMU buffer because we can't process data faster than the EKF prediction rate even if obs sensor reading-data speed is faster than the IMU update speed.
So, why we set beacon buffer length as imu_buffer_length+1, which >imu_buffer_length?
Can it be changed as:
?
The text was updated successfully, but these errors were encountered: