-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate FILES variable if PR contains one file in data/ #2595
Comments
Not a clue. In my experience, using Though the migration from Travis to Actions will require most existing PRs to be rebased, normally I don't think rebasing should be necessary. Primarily rebasing the master branch onto a PR or feature branch is required when the changes are dependent on a change that's been committed to master. Unfortunately that's not much help since right now, most of the existing PRs will need rebasing so they run the new test on Actions. I don't know how much difference there is in using |
Populate
FILES
variable if PR contains one file indata/
.Currently often in PRs the
FILES
variable is empty when an existing PR gets updated by pressing the "Update branch" button or using Mergify, e.g., here for f578718:#2541
Log:
https://github.com/AppImage/appimage.github.io/runs/3149918916
In those situations, I manually have to go into the file in
data/
in the PR, make a trivial edit (e.g., add a line with a#
in it) to trigger another test run where the changed file then is picked up in theFILES
variable.So we would somehow need to look at the PR and find out if file(s) in
data/
have been affected by the PR, and populate theFILES
variable with them.@andy5995 do you have an idea how to do that?
Without having this, using Mergify (which automates pressing the "Update branch" button) is of no actual use to us.
The text was updated successfully, but these errors were encountered: