Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Update branch" button disappears when branch protection is disabled #2593

Open
probonopd opened this issue Jul 24, 2021 · 4 comments
Open

"Update branch" button disappears when branch protection is disabled #2593

probonopd opened this issue Jul 24, 2021 · 4 comments

Comments

@probonopd
Copy link
Member

probonopd commented Jul 24, 2021 •
edited
Loading

Apparently we need to disable branch protection to allow GitHub Actions to push the files it generated to master.

But the "Update branch" button disappears when branch protection is disabled:

image

We need this button, but without enforcing branch protection...!
@probonopd
Copy link
Member Author

probonopd commented Jul 24, 2021 •
edited
Loading

As a workaround, add one "dummy" step before "build" that always passes and set up branch protection to require only it?

probonopd added a commit that referenced this issue Jul 24, 2021
@probonopd
Add a dummy job that always passes
7861888 
#2593
@probonopd
Copy link
Member Author

Confirmed, this gives us the "Update branch" button but also means more confusion because now two results are shown, one of which is always green:

image

@probonopd
Copy link
Member Author

probonopd commented Jul 24, 2021 •
edited
Loading

isaacs/github#1169

IMPORTANT NOTE: GITHUB NOW HAS AN OFFICIAL FEEDBACK REPOSITORY. OPEN A DISCUSSION THERE TO ASK QUESTIONS OR DISCUSS BUGS. THIS REPO IS DEPRECATED.

@probonopd probonopd mentioned this issue Jul 24, 2021
Merged
@probonopd
Copy link
Member Author

probonopd commented Jul 24, 2021 •
edited
Loading

Trying Mergify to do this automatically:
https://docs.mergify.io/actions/update/

Pending
#2595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@probonopd