Fix/wrong architecture string on appimagetool arch/1114 #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you want to hardcode I think this breaks bundling |
Ups, that's wrong. It should be fixed now |
azubieta
force-pushed
the
fix/wrong_architecture_string_on_appimagetool_arch/1114
branch
from
7f8b623
to
0c97ab5
Compare
|
Should I proceed with the merge? |
|
Lgtm. @TheAssassin? |
|
Is this still a thing? @TheAssassin wdyt? |
|
I totally agreed "arm_aarch64" is misleading, and the command-line help message doesn't provide this information, you have to look into the source code to find it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using armhf and aarch64 as architecture names on appimagetool. Doesn't remove the old names ("arm", "arm_aarch64") to avoid breaking scripts of possible users.
Closes #1114