Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd and Xcompression-level support #1091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ambyjkl
Copy link

@Ambyjkl Ambyjkl commented Nov 27, 2020

Resolves #478

I've actually not tested this yet. Please let me know if this is what you're looking for.

@TheAssassin
Copy link
Member

I've actually not tested this yet. Please let me know if this is what you're looking for.

I have no idea why you would submit a PR with untested code. It almost seems like you think we don't have the few minutes to write that code, but we have the time to test yours. At least you're honest, which is very much appreciated.

I didn't bother looking into it too deeply. There's more than just one workflow issue with this PR. I don't think it makes sense to review this any further.

@Ambyjkl
Copy link
Author

Ambyjkl commented Mar 23, 2021

Sorry I never got the chance to circle back. @TheAssassin sorry you feel that way, I didn't mean this PR to be an insult. I've never worked with this codebase before and I'm as busy as you are. I just wanted to understand if I'm headed in the right direction, so I can continue. If you don't have the time to help, feel free to close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use zstd compression
2 participants