Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add space above logo on welcome screen #5334

Merged
merged 1 commit into from
May 15, 2024

Conversation

Trapiz
Copy link
Contributor

@Trapiz Trapiz commented May 14, 2024

(Demo is done on Linux, but functions the same on Windows! The problem also occurred on Linux)

Screencast.from.2024-05-14.11-53-56.webm

Feature Preview

fixes


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

@Trapiz Trapiz changed the title fix: add space above logo fix: add space above logo on welcome screen May 14, 2024
@Xazin
Copy link
Collaborator

Xazin commented May 14, 2024

It seems something went wrong when merging or rebasing, as you have a lot of commits in your tree that is already merged.

Do you need help cleaning it up?

@Trapiz
Copy link
Contributor Author

Trapiz commented May 14, 2024

It seems something went wrong when merging or rebasing, as you have a lot of commits in your tree that is already merged.

Do you need help cleaning it up?

I just noticed that too! I'm not super experienced with Git yet so yes I would love some help.

@Trapiz Trapiz force-pushed the top_inset_welcome_screen_5304 branch from a408876 to 1c628ba Compare May 14, 2024 11:05
@Trapiz
Copy link
Contributor Author

Trapiz commented May 14, 2024

Figured it out!

@LucasXu0 LucasXu0 added bug Something isn't working v0.5.8 labels May 15, 2024
@Xazin Xazin merged commit c3c99c7 into AppFlowy-IO:main May 15, 2024
13 checks passed
@Trapiz Trapiz deleted the top_inset_welcome_screen_5304 branch May 16, 2024 09:15
zoli added a commit to zoli/AppFlowy that referenced this pull request May 16, 2024
* main:
  chore: update German translations with Fink 🐦 (AppFlowy-IO#5335)
  chore: bump version 0.5.8 (AppFlowy-IO#5341)
  fix: add space above logo (AppFlowy-IO#5334)
  feat: adjust font background color in dark mode (AppFlowy-IO#5333)
  feat: support enter to insert new line in callout (AppFlowy-IO#5331)
  chore: update translations with Fink 🐦 (AppFlowy-IO#5321)
  fix: font family warning (AppFlowy-IO#5329)
  fix: show windows title bar on sign in screen (AppFlowy-IO#5326)
  fix: view action not working (AppFlowy-IO#5325)
  fix: text update bug on number/url fields (AppFlowy-IO#5315)
  feat: settings manage data (AppFlowy-IO#5265)
  chore: improve floating mobile toolbar animation for iOS (AppFlowy-IO#5309)
  chore: udpated yrs to v0.18.8 (AppFlowy-IO#5316)
  fix: page style issues (AppFlowy-IO#5317)
  feat: custom windows title bar (AppFlowy-IO#5311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants