feat: integrate show notification button option #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Identical pattern | 688 | warning | contribute (via Fink 🐦) |
| Message without source | 84 | warning | contribute (via Fink 🐦) |
| Missing translation | 16497 | warning | contribute (via Fink 🐦) |
Xazin
reviewed
May 10, 2024
...wy_flutter/lib/workspace/application/settings/notifications/notification_settings_cubit.dart
Outdated
Show resolved
Hide resolved
...d/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart
Outdated
Show resolved
Hide resolved
...ppflowy_flutter/lib/workspace/presentation/settings/widgets/settings_notifications_view.dart
Outdated
Show resolved
Hide resolved
…widgets/settings_notifications_view.dart Co-authored-by: Mathias Mogensen <[email protected]>
…ions/widgets/notification_button.dart Co-authored-by: Mathias Mogensen <[email protected]>
Xazin
approved these changes
May 10, 2024
...wy_flutter/lib/workspace/application/settings/notifications/notification_settings_cubit.dart
Outdated
Show resolved
Hide resolved
…otifications/notification_settings_cubit.dart Co-authored-by: Mathias Mogensen <[email protected]>
|
Seems there are some issues due to merge. You might have to rename the usage of |
Resolved naming with this Widget. |
LucasXu0
force-pushed
the
feature/option-to-not-show-notifications-icon
branch
from
930f44c
to
f23d675
Compare
LucasXu0
force-pushed
the
feature/option-to-not-show-notifications-icon
branch
from
f23d675
to
6e925fe
Compare
zoli
added a commit
to zoli/AppFlowy
that referenced
this pull request
Jun 2, 2024
* main: (25 commits) fix: sidebar issues (AppFlowy-IO#5444) fix: notification test (AppFlowy-IO#5440) fix: some list icons don't align with the paragraph (AppFlowy-IO#5439) feat: integrate show notification button option (AppFlowy-IO#5302) feat: add border to selected unsplash image (AppFlowy-IO#5428) feat: sidebar UI Revamp on mobile (AppFlowy-IO#5418) chore: update German translations with Fink 🐦 (AppFlowy-IO#5421) chore: update Spanish translations (AppFlowy-IO#5205) feat: video block support (AppFlowy-IO#5199) feat: add reset app scale hotkey (AppFlowy-IO#5386) fix: sidebar issues on Windows and Linux (AppFlowy-IO#5431) feat: support web layout setting and breadcrumbs (AppFlowy-IO#5425) fix: dragging the Unsplash cover triggers an assertion error (AppFlowy-IO#5404) chore: improve hover and text colors in dark mode (AppFlowy-IO#5416) fix: accept multi-key combination for customizing shortcuts & removes duplicates (AppFlowy-IO#5414) feat: sidebar UI Revamp on Desktop (AppFlowy-IO#5343) fix: default text direction not synced (AppFlowy-IO#5405) chore: update German translations (AppFlowy-IO#5382) feat: support preview grid/board/calendar block on web (AppFlowy-IO#5401) feat: support open row page (AppFlowy-IO#5400) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
close #4847
Grabacion.2024-05-09.205742.mp4
PR Checklist