Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QWERTY keyboard with only 26 letters #2282

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Roffild
Copy link
Contributor

@Roffild Roffild commented May 21, 2020

Without popups.

You can not take your finger off the screen until you get to the desired letter.

@Roffild Roffild requested a review from a team as a code owner May 21, 2020 01:08
@menny
Copy link
Member

menny commented Jun 10, 2020

Can you provide a screenshot of this?
Also, what is the purpose of such a keyboard?

@Roffild
Copy link
Contributor Author

Roffild commented Jun 10, 2020

It looks like a standard keyboard.

Popup blocks the selection of a neighboring letter.

English only needs 26 letters.

@Roffild
Copy link
Contributor Author

Roffild commented Jul 7, 2020

You can click on the letter T, move your finger to the letter H and release. The letter H will be printed. On a standard keyboard, this will not make a popup on the letter G.

This keyboard is more convenient for the user who needs only 26 letters.

Additional characters are specified in the code and you can get rid of them only with: android:popupCharacters=""

protected boolean setupKeyAfterCreation(AnyKey key) {
if (super.setupKeyAfterCreation(key)) return true;
// ABCDEFGHIJKLMNOPQRSTUVWXYZ QWERTY KEYBOARD
// αβξδεφγθιϊκλμνοπψρστυϋωχηζ VIM digraphs
// ΑΒΞΔΕΦΓΘΙΪΚΛΜΝΟΠΨΡΣΤΥΫΩΧΗΖ VIM DIGRAPHS
// αβψδεφγηιξκλμνοπ;ρστθωςχυζ Greek layout
// ΑΒΨΔΕΦΓΗΙΞΚΛΜΝΟΠ;ΡΣΤΘΩΣΧΥΖ GREEK LAYOUT
// αβχδεφγηι κλμνοπθρστυ ωχψζ Magicplot
// ΑΒΧΔΕΦΓΗΙ ΚΛΜΝΟΠΘΡΣΤΥ ΩΧΨΖ MAGICPLOT
if (key.mCodes.length > 0) {

Copy link
Member

@menny menny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you added a layout to the main-app you probably need to fix some unit-tests that assume a certain number of main-app available layouts count.

@@ -1,6 +1,7 @@
<resources>
<string name="english_dictionary_description">English</string>
<string name="english_keyboard_description">QWERTY Latin keyboard</string>
<string name="english_26letters_keyboard_description">QWERTY keyboard with only 26 letters</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this to "QWERTY keyboard without any popups", or similar.

@Roffild Roffild requested a review from a team as a code owner July 8, 2020 17:16
@Roffild
Copy link
Contributor Author

Roffild commented Jul 8, 2020

No matter what the description and name of this keyboard will be.

This UnitTest is impossible to pass:

com.anysoftkeyboard.ime.AnySoftKeyboardKeyboardSubtypeTest > testAvailableSubtypesReported FAILED
   java.lang.AssertionError: expected:<8> but was:<9>

com.anysoftkeyboard.ime.AnySoftKeyboardKeyboardSubtypeTest > testAvailableSubtypesReported FAILED
   java.lang.AssertionError: expected:<9> but was:<8>

@nicoursi
Copy link
Contributor

nicoursi commented Aug 2, 2020

If you want to pass that awful test just have a look at how I did it here #2419

At one point, you will have to add and ID number into an array. Just invent one (no bigger then any number in that array) and add it as last number in the array. At this point you will fail the test, but you will know what ID to put (you'll find it in the error message). Make sure you put it at the right position, and delete the one you invented.

@menny menny force-pushed the master branch 5 times, most recently from 2999072 to ebc9b44 Compare February 10, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants