Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor structure into Router - Service - Repository + Improve Error Handling and Exceptions #121

Merged
merged 74 commits into from
Jun 5, 2024

Conversation

AntonioMrtz
Copy link
Owner

@AntonioMrtz AntonioMrtz commented Apr 6, 2024

Description

Refactor backend codebase for format, linting and enforcing separation between layers.

Commit type

Feat/Refactor

Issue

Solution

Proposed Changes

  • Divide logic into Router - Service - Repository
  • Use Exceptions as flow control
  • Add logging into Service-Repository
  • Move json logic into http_encode_service
  • Improve exception and error handling
  • Improve Database connection and stop app if connection failure
  • Add PropertiesMessagesManager for retrieving constant messages from messages.ini
  • Add patterns folder
  • Transform song_service_provider to Factory
  • Remove sdk architecture
  • Add validations modules both for repo and service
  • Add providers both for repo and service
  • Unify logic for user and artist
  • Unify logic for songs architectures

Potential Impact

Tests Performed

  • [✅] Test performed

Screenshots

Additional Tasks

Assigned

@AntonioMrtz

@AntonioMrtz AntonioMrtz changed the title refactor : json encode logic moved into http_encode_service" Refactor structure into Router - Service - Repository Apr 6, 2024
@AntonioMrtz AntonioMrtz changed the title Refactor structure into Router - Service - Repository Refactor structure into Router - Service - Repository + Improve Error Handling and Exceptions Apr 19, 2024
@AntonioMrtz AntonioMrtz added backend Backend related issues test Changes or improvements to tests refactor Code changes or imrprovements that do not change code behaviour labels Apr 20, 2024
@AntonioMrtz AntonioMrtz added documentation Improvements or additions to documentation frontend Frontend related issues labels Apr 20, 2024
Electron/src/__tests__/utils/Token.test.tsx Dismissed Show dismissed Hide dismissed
@AntonioMrtz AntonioMrtz self-assigned this May 17, 2024
@AntonioMrtz AntonioMrtz merged commit 25db28d into master Jun 5, 2024
9 checks passed
@AntonioMrtz AntonioMrtz deleted the refactor/Routers-Refactor branch June 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues documentation Improvements or additions to documentation frontend Frontend related issues refactor Code changes or imrprovements that do not change code behaviour test Changes or improvements to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant