Use CodeLingo to Address Further Issues #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeLingoTeam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AntoineAugusti!
Thanks for merging the fixes from our earlier pull request. They were generated by CodeLingo which we've used to find a further 64 issues in the repo, listed below. This PR adds a set of CodeLingo Tenets which catch any new cases of the found issues in PRs to your repo.
For example, Code Review Comments considers it bad practice to rename your imports unless there is a collision (implemented in this tenet), and considers it bad practice to capitalise error strings (tenet).
Examples in your codebase
Renamed imports:
main.go#L9
main.go#L11
repos/feature.go#L7
repos/feature.go#L8
models/feature.go#L8
services/features_test.go#L9
http/handlers_test.go#L15
Error strings:
repos/feature.go#L62
models/feature.go#L38
models/feature.go#L42
models/feature.go#L33
services/features.go#L25
First word should be the function name (tenet and Effective Go rule):
models/feature_test.go#L80
models/feature_test.go#L106
repos/feature.go#L75
models/feature_test.go#L9
repos/feature.go#L75
models/feature_test.go#L56
repos/feature.go#L12
repos/feature.go#L12
repos/feature.go#L49
repos/feature.go#L49
models/feature_test.go#L28
helpers/helpers_test.go#L9
models/feature.go#L29
models/feature.go#L29
helpers/helpers_test.go#L23
helpers/helpers.go#L7
helpers/helpers.go#L7
db/bucket.go#L14
helpers/helpers_test.go#L15
db/bucket.go#L14
services/features_test.go#L25
services/features.go#L54
services/features.go#L54
services/features.go#L82
services/features_test.go#L91
services/features.go#L82
services/features_test.go#L65
services/features.go#L89
services/features.go#L89
services/features.go#L15
services/features_test.go#L107
services/features.go#L15
http/logger.go#L10
services/features_test.go#L47
http/logger.go#L10
services/features_test.go#L15
http/router.go#L9
http/router.go#L9
http/handlers_test.go#L173
http/handlers_test.go#L227
http/handlers_test.go#L101
http/handlers_test.go#L42
http/handlers_test.go#L264
http/handlers_test.go#L72
http/handlers_test.go#L121
http/handlers.go#L33
http/handlers.go#L129
http/handlers.go#L147
http/handlers.go#L173
http/handlers.go#L68
http/handlers.go#L46
http/handlers.go#L99
CodeLingo will also send follow-up PRs to fix the existing repos in the codebase. Install CodeLingo GitHub app after merging this PR. It will always be free for open source.
We're most interested to see if we can help with project specific bugs. Tell us about more interesting issues and we'll see if our tech can help - free of charge.
Thanks,
Blake and the CodeLingo Team