Make skip silence configurable #7185
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- followup feed-specific skip silence config (AntennaPod#6910) - toggle buttons to configure - medium 300ms gap - aggressive 50ms gap
ByteHamster
changed the title
ByteHamster
reviewed
May 18, 2024
| OFF(0), GLOBAL(1), AGGRESSIVE(2); | ||
| GLOBAL(0), OFF(1), MEDIUM(2), AGGRESSIVE(3); |
There was a problem hiding this comment.
Please keep the IDs as they are. They don't have to be sorted but the meaning should stay the same. Otherwise this changes the existing settings for users when they upgrade.
| FeedPreferences.SkipSilence opt; | ||
| final int id = group.getCheckedButtonId(); | ||
| if (id == R.id.skipSilenceOff) opt = FeedPreferences.SkipSilence.OFF; | ||
| else if (id == R.id.skipSilenceMedium) opt = FeedPreferences.SkipSilence.MEDIUM; |
There was a problem hiding this comment.
Please use braces for all if/switch/etc statements. (I'm a bit surprised that the CI does not complain about this. Will have to check this)
| style="@style/OutlinedButtonBetterContrast" /> | ||
|
|
||
| <Button | ||
| android:id="@+id/skipSilenceMedium" |
There was a problem hiding this comment.
Please add the button suffix, similar for the other buttons. See also the code style guidelines: https://github.com/AntennaPod/AntennaPod/wiki/Code-style
Suggested change
| android:id="@+id/skipSilenceMedium" | |
| android:id="@+id/skipSilenceMediumButton" |
| android:layout_width="0dp" | ||
| android:layout_height="match_parent" | ||
| android:layout_weight="1" | ||
| android:text="Medium" |
There was a problem hiding this comment.
Please make this a @string/ resource, so it can be translated. Strings are stored in the ui/i18n module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4229
Description
Checklist
./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug