Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discord-bot): add "Feedback Command" #545

Closed
wants to merge 8 commits into from

Conversation

dhruv-kaushik
Copy link

@dhruv-kaushik dhruv-kaushik commented Feb 18, 2024

Description

Added the feedback Command but I need to know what needs to be done with the feedback..

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

N/A

Checklist:

  • I have performed a self-review of my own code
  • My PR title follows the semantic commits style

Copy link

vercel bot commented Feb 18, 2024

@dhruv-kaushik is attempting to deploy a commit to the Answer Overflow Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added 🤖bot Relates to the discord bot 📢 command labels Feb 18, 2024
@RhysSullivan
Copy link
Collaborator

Thanks for opening a PR!

For tracking the feedback, you can use the trackDiscordEvent function

You'll need to update the analytics package to include the event

Have the event name be "Feedback" with the properties:

"source": "slash-command"
"canFollowUp": Boolean, set based on slash command input
"type": "bug" | "suggestion"

Here's an example https://github.com/AnswerOverflow/AnswerOverflow/blob/main/apps/discord-bot/src/listeners/events/on-question-ask.ts

I'll take a deeper look tomorrow, also if adding the analytics event is a pain don't worry about it I can jump in this PR and update it

Comment on lines 118 to 123
type FeedbackGivenProps = ServerPropsWithDiscordData &
ChannelPropsWithDiscordData &
UserProps<'advisor'> & {
FeedbackType: 'Bug' | 'Suggestion';
CanFollowUp: boolean;
};
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

advisor is the person who gave the feedback, I couldn't think of a better name for that, Do i just use "feedbackGiver"? I want to know why we need source property in this ? and also are serverProps and ChannelProps needed in this type?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need source property

In the future, we'll be using this feedback event for multiple locations so the source will distinguish between them

also are serverProps and ChannelProps needed in this type

Sure lets include them, it'll be helpful to know where the feedback is coming from

feedbackGiver

Sure, that works for it

@github-actions github-actions bot added the 🎆event Event that can occur on the discord bot label Feb 20, 2024
@dhruv-kaushik
Copy link
Author

@RhysSullivan, i can't figure out stuff in events so just take over

@RhysSullivan
Copy link
Collaborator

@dhruv-kaushik will do, I'll get this merged tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖bot Relates to the discord bot 📢 command 🎆event Event that can occur on the discord bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants